Merge pull request microsoft#189007 from microsoft/constant-tarantula

fix memory leak

Author: rebornix

src/vs/workbench/contrib/notebook/browser/contrib/outline/notebookOutline.ts

@@ -314,6 +314,7 @@ export class NotebookCellOutline implements IOutline<OutlineEntry> {
 		this._onDidChange.dispose();
 		this._dispoables.dispose();
 		this._entriesDisposables.dispose();
+		this._outlineProvider?.dispose();
 	}
 }
 

src/vs/workbench/contrib/notebook/browser/notebookEditorWidget.ts

@@ -325,7 +325,7 @@ export class NotebookEditorWidget extends Disposable implements INotebookEditorD
 
 		this._register(this.instantiationService.createInstance(NotebookEditorContextKeys, this));
 
-		this._notebookOutline = this.instantiationService.createInstance(NotebookCellOutlineProvider, this, OutlineTarget.QuickPick);
+		this._notebookOutline = this._register(this.instantiationService.createInstance(NotebookCellOutlineProvider, this, OutlineTarget.QuickPick));
 
 		this._register(notebookKernelService.onDidChangeSelectedNotebooks(e => {
 			if (isEqual(e.notebook, this.viewModel?.uri)) {

src/vs/workbench/contrib/notebook/browser/viewModel/notebookOutlineProvider.ts

@@ -185,6 +185,7 @@ export class NotebookCellOutlineProvider {
 
 	dispose(): void {
 		// selectionListener.clear();
+		this._entriesDisposables.dispose();
 		this._dispoables.dispose();
 	}
 
@@ -329,6 +330,11 @@ export class NotebookCellOutlineProvider {
 			};
 			if (this._configurationService.getValue(OutlineConfigKeys.problemsEnabled)) {
 				markerServiceListener.value = this._markerService.onMarkerChanged(e => {
+					if (notebookEditorWidget.isDisposed) {
+						console.error('notebook editor is disposed');
+						return;
+					}
+
 					if (e.some(uri => notebookEditorWidget.getCellsInRange().some(cell => isEqual(cell.uri, uri)))) {
 						doUpdateMarker(false);
 						this._onDidChange.fire({});