Skip to content

Commit e50e7cb

Browse files
authored
Merge pull request microsoft#194332 from microsoft/merogge/polish-help-dialog
polish accessibility help dialog text
2 parents 94a48ba + e4ef0a9 commit e50e7cb

File tree

4 files changed

+12
-12
lines changed

4 files changed

+12
-12
lines changed

src/vs/editor/common/standaloneStrings.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@ export namespace AccessibilityHelpNLS {
2020
export const screenReaderModeDisabled = nls.localize("screenReaderModeDisabled", "Screen Reader Optimized Mode disabled.");
2121
export const tabFocusModeOnMsg = nls.localize("tabFocusModeOnMsg", "Pressing Tab in the current editor will move focus to the next focusable element. Toggle this behavior {0}.");
2222
export const tabFocusModeOnMsgNoKb = nls.localize("tabFocusModeOnMsgNoKb", "Pressing Tab in the current editor will move focus to the next focusable element. The command {0} is currently not triggerable by a keybinding.");
23-
export const stickScrollKb = nls.localize("stickScrollKb", "Run the command: Focus Sticky Scroll ({0}) to focus the currently nested scopes.");
24-
export const stickScrollNoKb = nls.localize("stickScrollNoKb", "Run the command: Focus Sticky Scroll to focus the currently nested scopes. It is currently not triggerable by a keybinding.");
23+
export const stickScrollKb = nls.localize("stickScrollKb", "Focus Sticky Scroll ({0}) to focus the currently nested scopes.");
24+
export const stickScrollNoKb = nls.localize("stickScrollNoKb", "Focus Sticky Scroll to focus the currently nested scopes. It is currently not triggerable by a keybinding.");
2525
export const tabFocusModeOffMsg = nls.localize("tabFocusModeOffMsg", "Pressing Tab in the current editor will insert the tab character. Toggle this behavior {0}.");
2626
export const tabFocusModeOffMsgNoKb = nls.localize("tabFocusModeOffMsgNoKb", "Pressing Tab in the current editor will insert the tab character. The command {0} is currently not triggerable by a keybinding.");
2727
export const showAccessibilityHelpAction = nls.localize("showAccessibilityHelpAction", "Show Accessibility Help");

src/vs/workbench/contrib/accessibility/browser/accessibilityContributions.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,12 +56,12 @@ export class EditorAccessibilityHelpContribution extends Disposable {
5656
await commandService.executeCommand(NEW_UNTITLED_FILE_COMMAND_ID);
5757
codeEditor = codeEditorService.getActiveCodeEditor()!;
5858
}
59-
accessibleViewService.show(instantiationService.createInstance(AccessibilityHelpProvider, codeEditor));
59+
accessibleViewService.show(instantiationService.createInstance(EditorAccessibilityHelpProvider, codeEditor));
6060
}, EditorContextKeys.focus));
6161
}
6262
}
6363

64-
class AccessibilityHelpProvider implements IAccessibleContentProvider {
64+
class EditorAccessibilityHelpProvider implements IAccessibleContentProvider {
6565
onClose() {
6666
this._editor.focus();
6767
}

src/vs/workbench/contrib/codeEditor/browser/diffEditorHelper.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ function createScreenReaderHelp(): IDisposable {
106106
const keys = ['audioCues.diffLineDeleted', 'audioCues.diffLineInserted', 'audioCues.diffLineModified'];
107107
const content = [
108108
localize('msg1', "You are in a diff editor."),
109-
localize('msg2', "View the next ({0}) or previous ({1}) diff in diff review mode that is optimized for screen readers.", next, previous),
109+
localize('msg2', "View the next ({0}) or previous ({1}) diff in diff review mode, which is optimized for screen readers.", next, previous),
110110
localize('msg3', "To control which audio cues should be played, the following settings can be configured: {0}.", keys.join(', ')),
111111
];
112112
const commentCommandInfo = getCommentCommandInfo(keybindingService, contextKeyService, codeEditor);

src/vs/workbench/contrib/comments/browser/comments.contribution.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -74,14 +74,14 @@ export namespace CommentAccessibilityHelpNLS {
7474
export const introWidgetNoKb = nls.localize('introWidgetNoKb', "This widget contains a text area, for composition of new comments, and actions, that can be tabbed to once tab moves focus mode has been enabled with the command Toggle Tab Key Moves Focus, which is currently not triggerable via keybinding.");
7575
export const commentCommands = nls.localize('commentCommands', "Some useful comment commands include:");
7676
export const escape = nls.localize('escape', "- Dismiss Comment (Escape)");
77-
export const nextRange = nls.localize('next', "- Navigate to the next commenting range ({0})");
77+
export const nextRange = nls.localize('next', "- Go to Next Commenting Range ({0})");
7878
export const nextRangeNoKb = nls.localize('nextNoKb', "- Go to Next Commenting Range, which is currently not triggerable via keybinding.");
79-
export const previousRange = nls.localize('previous', "- Navigate to the previous commenting range ({0})");
80-
export const previousRangeNoKb = nls.localize('previousNoKb', "Run the command: Go to Previous Commenting Range, which is currently not triggerable via keybinding.");
81-
export const nextCommentThreadKb = nls.localize('nextCommentThreadKb', "- Navigate to the next comment thread ({0})");
82-
export const nextCommentThreadNoKb = nls.localize('nextCommentThreadNoKb', "- Run the command: Go to Next Comment Thread, which is currently not triggerable via keybinding.");
83-
export const previousCommentThreadKb = nls.localize('previousCommentThreadKb', "- Navigate to the previous comment thread ({0})");
84-
export const previousCommentThreadNoKb = nls.localize('previousCommentThreadNoKb', "- Run the command: Go to Previous Comment Thread, which is currently not triggerable via keybinding.");
79+
export const previousRange = nls.localize('previous', "- Go to Previous Commenting Range ({0})");
80+
export const previousRangeNoKb = nls.localize('previousNoKb', "- Go to Previous Commenting Range, which is currently not triggerable via keybinding.");
81+
export const nextCommentThreadKb = nls.localize('nextCommentThreadKb', "- Go to Next Comment Thread ({0})");
82+
export const nextCommentThreadNoKb = nls.localize('nextCommentThreadNoKb', "- Go to Next Comment Thread, which is currently not triggerable via keybinding.");
83+
export const previousCommentThreadKb = nls.localize('previousCommentThreadKb', "- Go to Previous Comment Thread ({0})");
84+
export const previousCommentThreadNoKb = nls.localize('previousCommentThreadNoKb', "- Go to Previous Comment Thread, which is currently not triggerable via keybinding.");
8585
export const addComment = nls.localize('addComment', "- Add Comment ({0})");
8686
export const addCommentNoKb = nls.localize('addCommentNoKb', "- Add Comment on Current Selection, which is currently not triggerable via keybinding.");
8787
export const submitComment = nls.localize('submitComment', "- Submit Comment ({0})");

0 commit comments

Comments
 (0)