Skip to content

Commit eec2fc7

Browse files
Disable Local Server flow for REH (microsoft#191930)
Because spinning up ports on the remote won't always work. Instead, we have the trusty device code flow. Fixes microsoft#191866 Fixes microsoft#191867
1 parent 3cd6f48 commit eec2fc7

File tree

1 file changed

+3
-1
lines changed
  • extensions/github-authentication/src

1 file changed

+3
-1
lines changed

extensions/github-authentication/src/flows.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,9 @@ const allFlows: IFlow[] = [
200200
// other flows that work well.
201201
supportsGitHubEnterpriseServer: false,
202202
supportsHostedGitHubEnterprise: true,
203-
supportsRemoteExtensionHost: true,
203+
// Opening a port on the remote side can't be open in the browser on
204+
// the client side so this flow won't work in remote extension hosts
205+
supportsRemoteExtensionHost: false,
204206
// Web worker can't open a port to listen for the redirect
205207
supportsWebWorkerExtensionHost: false,
206208
// exchanging a code for a token requires a client secret

0 commit comments

Comments
 (0)