-
Notifications
You must be signed in to change notification settings - Fork 0
chore: standardize Docker base images to approved platform images #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| FROM mcr.microsoft.com/devcontainers/base:ubuntu-24.04 | ||
| # Standardized to approved base image (ubuntu:22.04 instead of ubuntu-24.04 devcontainer base) | ||
| FROM ubuntu:22.04 | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ℹ️ Info: Updated from Key differences:
Why this works:
|
||
|
|
||
| # use this Dockerfile to install additional tools you might need, e.g. | ||
| # RUN apt-get update && export DEBIAN_FRONTEND=noninteractive \ | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pre-installed in devcontainer base (now missing):
git,sudo,wget,vim,less,jq,openssh-clientvscodeuser with passwordless sudoAction required: If your workflow depends on any of these tools, add them explicitly to the Dockerfile. For example:
RUN apt-get update && apt-get install -y git sudo vim && rm -rf /var/lib/apt/lists/*