-
Notifications
You must be signed in to change notification settings - Fork 0
chore: standardize Docker base images to approved platform images #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| # Standardized to approved base image - using Ubuntu 22.04 LTS | ||
| FROM ubuntu:22.04 | ||
|
|
||
| # use this Dockerfile to install additional tools you might need, e.g. | ||
| # RUN apt-get update && export DEBIAN_FRONTEND=noninteractive \ | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ubuntu 24.04 → 22.04 considerations:
If you need to install packages, use this pattern: RUN apt-get update && export DEBIAN_FRONTEND=noninteractive \
&& apt-get -y install --no-install-recommends \
git curl wget ca-certificates \
&& apt-get clean && rm -rf /var/lib/apt/lists/*Testing recommendation: |
||
| # && apt-get -y install --no-install-recommends <your-package-list-here> | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| FROM ruby:3.1.1-alpine3.15 | ||
| # Standardized to approved base image - updated to latest stable Ruby on Alpine | ||
| FROM ruby:3.3.6-alpine3.21 | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ℹ️ Info: Updated from What changed:
Why:
Compatibility notes:
|
||
|
|
||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👀 Review: Package installation compatibility check Packages being installed via apk (Alpine package manager):
Action required: Note: Alpine 3.21 updates may affect native gem compilation. Watch for issues with gems that have C extensions. |
||
| RUN apk add --update build-base bash git bash-completion libffi-dev tzdata postgresql-client postgresql-dev nodejs npm yarn | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👀 Review: Package installation compatibility check Packages being installed via apk (Alpine package manager):
Action required: Note: Alpine 3.21 includes PostgreSQL 16 client by default. If you need a specific version, you may need to pin it. |
||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ℹ️ Info: Replaced Microsoft dev container base with approved Ubuntu 22.04 LTS
What changed:
mcr.microsoft.com/devcontainers/base:ubuntu-24.04(Microsoft-specific, Ubuntu 24.04)ubuntu:22.04(Official Ubuntu image, LTS release)Why:
Important compatibility notes:
⚠️ The Microsoft dev container base includes pre-installed tools (git, curl, wget, sudo, etc.)
⚠️ The official
ubuntu:22.04image is minimal and may require additional tool installationAction required:
👀 Review the commented example on lines 5-6 - you may need to install additional packages
👀 Common tools to consider:
git,curl,wget,sudo,ca-certificates,build-essential