-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
ui: update how tags look like #1002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Armatorix
wants to merge
15
commits into
gitroomhq:main
Choose a base branch
from
Armatorix:feature/tags
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Armatorix is attempting to deploy a commit to the Listinai Team on Vercel. A member of the Team first needs to authorize it. |
e13099a
to
1ca1d21
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
TLDR: Change behavior of the tags and how they look like


Previously it was possible to modify and delete the tag from the post directly from the post view.
and they were without colors in the options list
With this implementation it's only possible to delete and modify tags from the list.

Why was this change needed?
Not found any issue - wanted to simplify this feature and (hopefully) make it a better UX.
Other information:
Still requies additional work for overflow state and usage of the colors on the calendera view - to make some actual useage of the colors assigned to the tags.
Checklist:
Put a "X" in the boxes below to indicate you have followed the checklist;