fix: remove incorrect RefreshToken throw from Bluesky provider#1202
Open
smith-and-web wants to merge 1 commit intogitroomhq:mainfrom
Open
fix: remove incorrect RefreshToken throw from Bluesky provider#1202smith-and-web wants to merge 1 commit intogitroomhq:mainfrom
smith-and-web wants to merge 1 commit intogitroomhq:mainfrom
Conversation
Bluesky uses password-based authentication stored in customInstanceDetails, not OAuth tokens. The getAgent() method re-authenticates on every operation. Previously, if login failed, it threw RefreshToken which triggered the token refresh flow. Since Bluesky doesn't support token refresh (refreshToken() returns empty values), this caused the integration to be disconnected. Now login errors propagate naturally without triggering the refresh flow, allowing proper error handling upstream.
|
@smith-and-web is attempting to deploy a commit to the Listinai Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RefreshTokenexception throw fromgetAgent()in the Bluesky providercustomInstanceDetails), not OAuth tokensrefreshToken()method returns empty values, so throwingRefreshTokencaused integrations to disconnectProblem
When the Bluesky
getAgent()method encountered a login error, it threwRefreshToken. This triggered the token refresh flow inRefreshIntegrationService, which:refreshToken()on the Bluesky providerdisconnectChannel()since refresh "failed"This caused Bluesky integrations to be marked as disconnected even for transient errors.
Solution
Let login errors propagate naturally instead of wrapping them in
RefreshToken. This allows upstream code to handle the error appropriately without triggering the token refresh flow that doesn't apply to password-based providers.Test plan