Skip to content

fix/sentry crash modal #926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix/sentry crash modal #926

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
06b309e
fix/sentry crash modal
egelhaus Aug 4, 2025
1862ebb
Merge branch 'main' into sentry-fix-crash-modal
egelhaus Aug 4, 2025
370fdbe
Update libraries/react-shared-libraries/src/sentry/initialize.sentry.…
egelhaus Aug 4, 2025
f76762b
Update libraries/react-shared-libraries/src/sentry/initialize.sentry.…
egelhaus Aug 4, 2025
ff39159
revert copilot changes
egelhaus Aug 4, 2025
4e56391
error catching for crash modal
egelhaus Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions libraries/react-shared-libraries/src/sentry/initialize.sentry.client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,19 @@ export const initializeSentryClient = (environment: string, dsn: string) =>
autoInject: false,
}),
],
beforeSend(event: Sentry.Event, hint: Sentry.EventHint) {
// Check if it is an exception, and if so, show the report dialog
if (event.exception && event.event_id) {
try {
Sentry.showReportDialog({ eventId: event.event_id });
} catch (err) {
// Prevent error reporting from causing its own errors
// Optionally log the error for debugging
// console.error('Failed to show Sentry report dialog:', err);
Copy link
Preview

Copilot AI Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the project's Sentry logging guidelines, error logging should use Sentry's structured logger instead of console.error. Consider using logger.error() from Sentry with appropriate context if this line is uncommented.

Copilot generated this review using guidance from copilot-instructions.md.

}
}
return event;
},
replaysSessionSampleRate: environment === 'development' ? 1.0 : 0.1,
replaysOnErrorSampleRate: environment === 'development' ? 1.0 : 0.1,
});