Skip to content

Conversation

Y0ngg4n
Copy link

@Y0ngg4n Y0ngg4n commented Aug 8, 2025

What kind of change does this PR introduce?

createCipher is deprecated and @aumetra helped me to change it to the new function definition.
It also adds a flake.nix for nixos development.

Why was this change needed?

createCipher is deprecated

Other information:

eg: Did you discuss this change with anybody before working on it (not required, but can be a good idea for bigger changes). Any plans for the future, etc?

Checklist:

Put a "X" in the boxes below to indicate you have followed the checklist;

  • I have read the CONTRIBUTING guide.
  • I checked that there were not similar issues or PRs already open for this.
  • This PR fixes just ONE issue (do not include multiple issues or types of change in the same PR) For example, don't try and fix a UI issue and include new dependencies in the same PR.

Copy link

vercel bot commented Aug 8, 2025

Someone is attempting to deploy a commit to the Listinai Team on Vercel.

A member of the Team first needs to authorize it.

@aumetra
Copy link

aumetra commented Aug 8, 2025

(side note: In order to use AES-CBC correctly here, I'd generate a random IV and append it to the end of the cipher text. Then in the decryption you can retrieve it by splitting off the last 16 bytes of the ciphertext. I forgot to mention it that evening when I helped you out, @Y0ngg4n)

(side side note (this goes more to the maintainers): Is there a specific reason why CBC is used as the mode, as opposed to AES-GCM-SIV? Or was it just used because it came to mind first?)

@Eshwar1212-maker
Copy link

Nice PR! It seems the maintainer for this repo doesnt review PRs? Is he busy? I see alot of good ones and i made a few as well.

@Y0ngg4n
Copy link
Author

Y0ngg4n commented Aug 18, 2025

Nice PR! It seems the maintainer for this repo doesnt review PRs? Is he busy? I see alot of good ones and i made a few as well.

I dont know :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants