-
Notifications
You must be signed in to change notification settings - Fork 53
fix auth redirect url updating oauth2redirect.tsx #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Some providers does not accept http as redirect uri (facebook and instagram for example), i tried it locally and its worked with the url: https://redirectmeto.com/http://localhost:4200/integrations/social/{provider}
Update oauth2redirect.tsx
@talkenigs is attempting to deploy a commit to the Listinai Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe update introduces an additional list item in the Changes
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
components/snippets/oauth2redirect.tsx (1)
19-19
: Good addition for Facebook and Instagram compatibility!This is a helpful addition that addresses the issue with providers like Facebook and Instagram that don't accept HTTP URIs as redirect targets. The solution of using
redirectmeto.com
as a HTTPS wrapper is practical for local development scenarios.However, it's worth considering the security implications of using a third-party redirect service in an OAuth flow. For production environments, users should be encouraged to use proper HTTPS endpoints rather than this workaround.
Consider adding a brief note about this being primarily for development purposes, and mentioning alternative approaches for production environments.
Some providers does not accept http as redirect uri (facebook and instagram for example)

`
Summary by CodeRabbit