Skip to content

WIP - Use upstream scrollbar instead of custom one #2393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

WIP - Use upstream scrollbar instead of custom one #2393

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions src/components/utils/scroll_vertical.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
use crate::{
components::ScrollType,
ui::{draw_scrollbar, style::SharedTheme, Orientation},
use crate::{components::ScrollType, ui::style::SharedTheme};
use ratatui::widgets::{
Scrollbar, ScrollbarOrientation, ScrollbarState,
};
use ratatui::{layout::Rect, Frame};
use std::cell::Cell;
Expand Down Expand Up @@ -107,15 +107,15 @@ impl VerticalScroll {
self.update(self.get_top(), line_count, visual_height)
}

pub fn draw(&self, f: &mut Frame, r: Rect, theme: &SharedTheme) {
draw_scrollbar(
f,
r,
theme,
self.max_top.get(),
self.top.get(),
Orientation::Vertical,
);
pub fn draw(&self, f: &mut Frame, r: Rect, _theme: &SharedTheme) {
let scrollbar =
Scrollbar::new(ScrollbarOrientation::VerticalRight);

let mut scrollbar_state =
ScrollbarState::new(self.max_top.get())
.position(self.top.get());

f.render_stateful_widget(scrollbar, r, &mut scrollbar_state);
}
}

Expand Down