Skip to content

Conversation

naseschwarz
Copy link
Contributor

@naseschwarz naseschwarz commented Apr 16, 2025

It changes the following:

  • Removes a few outdated or easy to fix #[allow]s

I followed the checklist:

  • I added unittests
  • I ran make check without errors
  • I tested the overall application
    • Explicitly tested the ghemoji feature
  • I added an appropriate item to the changelog

@naseschwarz
Copy link
Contributor Author

naseschwarz commented Apr 16, 2025

This brings rg '#.*allow' | wc -l from 38 down to 31 28.

Naseschwarz added 2 commits April 16, 2025 10:34
This avoids unnecessary mut magic outside of this function
@extrawurst extrawurst merged commit e08d954 into gitui-org:master Apr 16, 2025
22 checks passed
@extrawurst
Copy link
Collaborator

Awesome! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants