Skip to content

Remove some #[allow]s II #2616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 18, 2025
Merged

Remove some #[allow]s II #2616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b225504
Disallow unstable_name_collisions
Apr 16, 2025
fe8aabb
Remove allow clippy::option_if_let_else
Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/args.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ pub fn process_cmdline() -> Result<CliArgs> {
.get_one::<String>("directory")
.map_or_else(|| PathBuf::from("."), PathBuf::from);

#[allow(clippy::option_if_let_else)]
let repo_path = if let Some(w) = workdir {
RepoPath::Workdir { gitdir, workdir: w }
} else {
Expand Down
1 change: 0 additions & 1 deletion src/components/commit_details/compare_details.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ impl CompareDetailsComponent {
});
}

#[allow(unstable_name_collisions)]
fn get_commit_text(&self, data: &CommitDetails) -> Vec<Line> {
let mut res = vec![
Line::from(vec![
Expand Down
2 changes: 1 addition & 1 deletion src/components/commit_details/details.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ impl DetailsComponent {
.collect()
}

#[allow(unstable_name_collisions, clippy::too_many_lines)]
#[allow(clippy::too_many_lines)]
fn get_text_info(&self) -> Vec<Line> {
self.data.as_ref().map_or_else(Vec::new, |data| {
let mut res = vec![
Expand Down
Loading