Print a nicer error when failing to create the cache directory #2728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, #2684 already fixed half of this issue, I should have checked before opening it… @sobczal2, @cruessler, do you want to merge the cache half of this PR into the existing one, or just to merge this one and also credit @sobczal2? |
|
I’ve rebased on top of the now-merged #2684, using the same |
Same as in 1d22485 for the config directory, when the cache directory fails to get created for whichever reason, we currently exit gitui with a pretty undescriptive error. Improves on gitui-org#2684. Fixes gitui-org#2652.
linkmauve
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the config or cache directories fail to get created for whichever reason, we currently exit gitui with a pretty undescriptive error.
This at least prints the relevant path so that the user can attempt to fix them.
Fixes #2652.
This Pull Request fixes/closes #2652.
It changes the following:
I followed the checklist:
make checkwithout errors