fixed table export to csv with empty cells (#2028)

giuspen · giuspen · commit b0d7037053ee · 2025-02-04T21:59:33.000Z
diff --git a/src/ct/ct_misc_utils.cc b/src/ct/ct_misc_utils.cc
@@ -105,10 +105,11 @@ std::string CtCSV::table_to_csv(const CtStringTable& table)
 {
     std::string ret_str;
     for (const auto& row : table) {
-        for (const auto& cell : row) {
-            ret_str += fmt::format("\"{}\"", str::replace(cell, std::string{"\""}, std::string{"\\\""}));
+        const size_t numCols = row.size();
+        for (size_t i = 0u; i < numCols; ++i) {
+            ret_str += fmt::format("\"{}\"", str::replace(row.at(i), std::string{"\""}, std::string{"\\\""}));
 
-            if (cell != row.back()) ret_str += ",";
+            if (i < (numCols - 1u)) ret_str += ",";
         }
         ret_str += "\n";
     }

Original file line number	Diff line number	Diff line change
`@@ -105,10 +105,11 @@ std::string CtCSV::table_to_csv(const CtStringTable& table)`
`105`	`105`	`{`
`106`	`106`	`std::string ret_str;`
`107`	`107`	`for (const auto& row : table) {`
`108`		`- for (const auto& cell : row) {`
`109`		`- ret_str += fmt::format("\"{}\"", str::replace(cell, std::string{"\""}, std::string{"\\\""}));`
	`108`	`+ const size_t numCols = row.size();`
	`109`	`+ for (size_t i = 0u; i < numCols; ++i) {`
	`110`	`+ ret_str += fmt::format("\"{}\"", str::replace(row.at(i), std::string{"\""}, std::string{"\\\""}));`
`110`	`111`
`111`		`- if (cell != row.back()) ret_str += ",";`
	`112`	`+ if (i < (numCols - 1u)) ret_str += ",";`
`112`	`113`	`}`
`113`	`114`	`ret_str += "\n";`
`114`	`115`	`}`