Open
Conversation
added 3 commits
August 19, 2020 01:29
This produced a nonsensical warning in client mode. It is also redundant as there is this line: log_printf(L_INFO, "Server in ToxID whitelisting mode - only clients listed with -i can connect");
The client and server blocks were nearly identical. Now they share code. Both client and server now call memset() on tox_printable_id. The distinct client message "Generated Tox ID: %s\n" was not preserved; both client and server will say "Using Tox ID: %s\n" which is more accurate (Tox ID might be persistent with -C).
|
Kudos, SonarCloud Quality Gate passed!
|
Owner
|
Alright, will test and merge. I don't like removing the debug printf - if you don't like it, don't run with -d? |
Author
|
To be clear: I removed it because (1) it's inaccurate -- it says something about "server" when in client mode; and (2) it's redundant -- the other debug printf triggers in exactly the same conditions; not because I don't like it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wrote a few commits, that don't change very much, but are improvements.
Thanks for creating
tuntox.