lint

Author: gjtorikian

lib/html_pipeline.rb

@@ -81,7 +81,7 @@ def require_dependencies(names, requirer)
     def define_dependency_loaded_method(name, value)
       self.class.define_method(:"#{name}_loaded?", -> { value })
     end
-end
+  end
   # Public: Returns an Array of Filter objects for this Pipeline.
   attr_reader :text_filters, :node_filters
 

lib/html_pipeline/convert_filter.rb

@@ -12,6 +12,6 @@ class << self
       def call(text, context: {}, result: {})
         new(context: context, result: result).call(text)
       end
-  end
+    end
   end
 end

lib/html_pipeline/filter.rb

@@ -49,7 +49,7 @@ class << self
       def call(input, context: {})
         raise NoMethodError
       end
-  end
+    end
     # Make sure the context has everything we need. Noop: Subclasses can override.
     def validate; end
 

lib/html_pipeline/node_filter/asset_proxy_filter.rb

@@ -37,7 +37,7 @@ def handle_element(element)
       end
 
       def validate
-        needs(:asset_proxy, :asset_proxy_secret_key) if asset_proxy_enabled?
+        needs(:asset_proxy, :asset_proxy_secret_key)
       end
 
       def asset_host_allowed?(host)
@@ -74,11 +74,11 @@ def determine_allowlist(proxy_settings)
         "#{context[:asset_proxy]}/#{asset_url_hash(url)}/#{hexencode(url)}"
       end
 
-      def asset_url_hash(url)
+      private def asset_url_hash(url)
         OpenSSL::HMAC.hexdigest("sha1", context[:asset_proxy_secret_key], url)
       end
 
-      def hexencode(str)
+      private def hexencode(str)
         str.unpack1("H*")
       end
     end

lib/html_pipeline/node_filter/mention_filter.rb

@@ -38,7 +38,7 @@ def mentioned_logins_in(text, username_pattern = USERNAME_PATTERN)
             yield match, login
           end
         end
-    end
+      end
       # Hash that contains all of the mention patterns used by the pipeline
       MENTION_PATTERNS = Hash.new do |hash, key|
         hash[key] = %r{

lib/html_pipeline/node_filter/team_mention_filter.rb

@@ -35,7 +35,7 @@ def mentioned_teams_in(text, team_pattern = TEAM_PATTERN)
             yield match, org, team
           end
         end
-    end
+      end
 
       # Default pattern used to extract team names from text. The value can be
       # overridden by providing the team_pattern variable in the context. To

lib/html_pipeline/sanitization_filter.rb

@@ -183,6 +183,6 @@ def call(html, config)
         sanitization_config = Selma::Sanitizer.new(config)
         Selma::Rewriter.new(sanitizer: sanitization_config).rewrite(html)
       end
-  end
+    end
   end
 end

lib/html_pipeline/text_filter.rb

@@ -16,6 +16,6 @@ class << self
       def call(input, context: {}, result: {})
         new(input, context: context, result: result).call
       end
-  end
+    end
   end
 end