Merged
Conversation
|
I recommend using something like https://github.com/jwalton/go-supportscolor. This is for example useful on CI environments like GitHub Actions which can display color while not setting the |
Owner
Author
|
Hey @silverwind unfortunately I don't think even your suggestion would do the trick to detect if the go test is running in a terminal that supports color. This pr is me exploring a solution, also #122 (comment) |
|
Sounds like the stdout you see in tests is not the real one? Yeah it's hard if that's the case. |
|
Maybe just always output color except when |
d0ef4bf to
9f7b58d
Compare
9f7b58d to
23fa7bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #122