Open
Conversation
Author
Contributor
|
I didn't know that syncing closes a PR but thanks for the persistence! |
Collaborator
|
Hi @BastienZim, a big change was made today (#33) that has made this pull request outdated. I apologize for the inconvenience. If it is easier, please feel free to open a new pull request with the changes using the latest code. |
BastienZim
force-pushed
the
main
branch
2 times, most recently
from
feb6001 to
581ff43
Compare
Author
|
@kedarchandrayan. It should be good now. |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I was going through the code to understand what the evaluation was doing, I encountered this typo.
This affects the whole evaluation process and might bias the results.
This is why I would consider incorporating this change.
NB: this is a follow-up PR of "Fixed a typo in evaluation function #9"