Viewer: Added DRACO and KTX2 support #701
Merged
+11
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrdoob
force-pushed
the
viewer-draco-ktx2
branch
from
0a8a8ca to
e420611
Compare
mrdoob
force-pushed
the
viewer-draco-ktx2
branch
from
e420611 to
c672e82
Compare
Contributor
Author
|
Rebased. |
Owner
Yeah this is likely from the step where the geometry is transformed by the world matrix and buffers are transformed into a data texture for GPU use. An issue for another day 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #699
This PR adds DRACO and KTX2 support to the drag & drop viewer.
Tried to add support for Meshopt too but seems like the pathtracer doesn't support those types of buffer/geometries yet.