Skip to content

Auto parse json.ls with lsc #884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nekdolan wants to merge 1 commit into from
Closed

Auto parse json.ls with lsc #884

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions lib/node.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 5 additions & 1 deletion src/node.ls
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,11 @@ module.exports = !(LiveScript) ->
LiveScript <<<< events.EventEmitter.prototype

require.extensions.'.ls' = (module, filename) ->
js = LiveScript.compile (fs.read-file-sync filename, 'utf8'), {filename, +bare, map: "embedded"} .code
file = (fs.read-file-sync filename, 'utf8')
if (filename.substr -7) is 'json.ls'
Copy link
Contributor

@vendethiel vendethiel Apr 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. that's not our codestyle
  2. doesn't work with foobarjson.ls.

Copy link
Author

@nekdolan nekdolan Apr 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vendethiel can you give me some hints or instructions for the code style? I am a beginner when it comes to livescript and functional programming.

Copy link
Contributor

@vendethiel vendethiel Apr 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just look at the rest of the codebase

and for the second point, check one more char

js = 'module.exports = ' + LiveScript.compile file, {filename, +json}
else
js = LiveScript.compile file, {filename, +bare, map: "embedded"} .code
try
module._compile js, filename
catch
Expand Down