Skip to content

feat: fixes various fire alarms clipping in walls#380

Draft
Luiluix wants to merge 2 commits intoglacier-modding:mainfrom
Luiluix:FireAlarmClippingFix
Draft

feat: fixes various fire alarms clipping in walls#380
Luiluix wants to merge 2 commits intoglacier-modding:mainfrom
Luiluix:FireAlarmClippingFix

Conversation

@Luiluix
Copy link
Contributor

@Luiluix Luiluix commented Mar 14, 2025

This fix moves various fire alarms slightly forward so that wall geometry doesn't clip into them, this in an ongoing fix that can be continued by other contributors

@Luiluix Luiluix changed the title Fixes various fire alarms clipping in walls feat: Fixes various fire alarms clipping in walls Mar 14, 2025
@Luiluix Luiluix force-pushed the FireAlarmClippingFix branch from ff59588 to 7886556 Compare March 14, 2025 17:34
This fix moves various fire alarms slightly forward so that wall geometry doesn't clip into them, this in an ongoing fix that can be continued by other contributors
@Luiluix Luiluix changed the title feat: Fixes various fire alarms clipping in walls feat: fixes various fire alarms clipping in walls Mar 14, 2025
@Luiluix Luiluix force-pushed the FireAlarmClippingFix branch from 7886556 to 608135d Compare March 14, 2025 17:41
@VoodooHillbilly
Copy link
Member

Since you added a new main content folder, you also need to add "content/FireAlarmClippingFix" to the list of contentFolders in the manifest.

@Luiluix
Copy link
Contributor Author

Luiluix commented Mar 15, 2025

Can I ammend and add the manifest change to the same commit? Or is it necessary to make a new one

@VoodooHillbilly
Copy link
Member

Yeah you can just add another commit to the PR.

updated the manifest for the fire alarms fix to be usable
@Ocean-Minnow
Copy link
Contributor

Ocean-Minnow commented May 13, 2025

I want to test this, but I'm not clear on where exactly the fire alarms are. Could you provide some extra details? Thanks :]

@Luiluix
Copy link
Contributor Author

Luiluix commented May 26, 2025

Just saw this, it's a little difficult to list but you can search by entityIDs in the SDK editor to find them more easily, I just remember fixing the ones in the school and consulate in Marrakesh but can't remember where the others are located

@VoodooHillbilly
Copy link
Member

I checked them all out yesterday. I think SetPiece_Activator_FireAlarm22 c6b78d19313904f3 in mission_marrakesh_spider.entity.patch.json needs to be moved a little more to get rid of the clipping.

SetPiece_Activator_FireAlarm22 c6b78d19313904f3

A lot of the others are still clipping into the walls a bit. Here's a couple of examples: SetPiece_Activator_FireAlarm12 0e5bf490b54dd2e1 and SetPiece_Activator_FireAlarm13 2ddc8544ec72af04. I don't know if it makes them look out of place for everyone else or not.

SetPiece_Activator_FireAlarm12 0e5bf490b54dd2e1 and SetPiece_Activator_FireAlarm13 2ddc8544ec72af04

Here's what one of the vanilla fire alarms in Bangkok look like for reference.

SetPiece_Activator_FireAlarm_SECURITY_ROOM_HOTEL 2b3433b43f7e56c8

@Ocean-Minnow Ocean-Minnow marked this pull request as draft September 4, 2025 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants