[WIP] - 8.4 Asymmetric Visibility support#1148
Draft
genintho wants to merge 1 commit intoglayzzle:mainfrom
Draft
[WIP] - 8.4 Asymmetric Visibility support#1148genintho wants to merge 1 commit intoglayzzle:mainfrom
genintho wants to merge 1 commit intoglayzzle:mainfrom
Conversation
Collaborator
Author
|
@czosel @cseufert This is work in progress, but I would like to hear your thoughts on the approach. I tried to create a new token for I ended creating an intermediate object to store the various flags as it made things simpler to understand and removes a lot of duplication. One thing I keep going back and forth is if the AST we create should match 100% the code or if it should match the intent of the code. For example |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1144