refactor(dependencies): only check for major versions on update and download ♻️

Author: andho

compiler-cli/src/add.rs

@@ -33,6 +33,7 @@ pub fn command(paths: &ProjectPaths, packages_to_add: Vec<String>, dev: bool) ->
         Some((new_package_requirements.clone(), dev)),
         Vec::new(),
         UseManifest::Yes,
+        false,
     )?;
 
     // Read gleam.toml and manifest.toml so we can insert new deps into it

compiler-cli/src/dependencies.rs

@@ -88,6 +88,7 @@ fn get_manifest_details(paths: &ProjectPaths) -> Result<(PackageConfig, Manifest
         Mode::Dev,
         UseManifest::Yes,
         cli::Reporter::new(),
+        false,
     );
     let (_, manifest) = dependency_manager.get_manifest(&paths, &config, Vec::new())?;
     Ok((config, manifest))
@@ -217,6 +218,7 @@ pub fn update(paths: &ProjectPaths, packages: Vec<String>) -> Result<()> {
         None,
         packages.into_iter().map(EcoString::from).collect(),
         use_manifest,
+        true,
     )?;
 
     Ok(())
@@ -353,6 +355,8 @@ pub fn download<Telem: Telemetry>(
     // manifest which will result in the latest versions of the dependency
     // packages being resolved (not the locked ones).
     use_manifest: UseManifest,
+    // If true we check for major version updates and print them to the console.
+    check_major_versions: bool,
 ) -> Result<Manifest> {
     let mode = Mode::Dev;
 
@@ -366,6 +370,7 @@ pub fn download<Telem: Telemetry>(
         mode,
         use_manifest,
         telemetry,
+        check_major_versions,
     );
 
     dependency_manager.download(paths, new_package, packages_to_update)
@@ -646,6 +651,7 @@ struct DependencyManager<Telem: Telemetry, P: dependency::PackageFetcher> {
     mode: Mode,
     use_manifest: UseManifest,
     telemetry: Telem,
+    check_major_versions: bool,
 }
 
 impl<Telem: Telemetry, P> DependencyManager<Telem, P>
@@ -658,13 +664,15 @@ where
         mode: Mode,
         use_manifest: UseManifest,
         telemetry: Telem,
+        check_major_versions: bool,
     ) -> Self {
         Self {
             runtime,
             package_fetcher,
             mode,
             use_manifest,
             telemetry,
+            check_major_versions,
         }
     }
 
@@ -772,13 +780,15 @@ where
         }
         LocalPackages::from_manifest(&manifest).write_to_disc(paths)?;
 
-        let major_versions_available =
-            dependency::check_for_major_version_updates(&manifest, &self.package_fetcher);
-        if !major_versions_available.is_empty() {
-            eprintln!(
-                "{}",
-                pretty_print_major_versions_available(major_versions_available)
-            );
+        if self.check_major_versions {
+            let major_versions_available =
+                dependency::check_for_major_version_updates(&manifest, &self.package_fetcher);
+            if !major_versions_available.is_empty() {
+                eprintln!(
+                    "{}",
+                    pretty_print_major_versions_available(major_versions_available)
+                );
+            }
         }
 
         Ok(manifest)

compiler-cli/src/fs.rs

@@ -246,7 +246,14 @@ impl MakeLocker for ProjectIO {
 
 impl DownloadDependencies for ProjectIO {
     fn download_dependencies(&self, paths: &ProjectPaths) -> Result<Manifest> {
-        crate::dependencies::download(paths, NullTelemetry, None, Vec::new(), UseManifest::Yes)
+        crate::dependencies::download(
+            paths,
+            NullTelemetry,
+            None,
+            Vec::new(),
+            UseManifest::Yes,
+            false,
+        )
     }
 }
 

compiler-cli/src/lib.rs

@@ -782,6 +782,7 @@ fn download_dependencies(paths: &ProjectPaths) -> Result<()> {
         None,
         Vec::new(),
         UseManifest::Yes,
+        true,
     )?;
     Ok(())
 }