Offline package resolution #4963
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have opened this because I am ready for feedback on anything/everything. Before this is merged: JSON caching is an area of major concern as it is unsigned and unverifiable. I am currently looking into ways to either cache it safely, use another safe source, or validate with another safe source (match checksum from protobuf content). |
benev0
commented
Sep 22, 2025
compiler-cli/src/dependencies.rs
Outdated
Comment on lines
1120
to
1133
| let cached_result = | ||
| fs.read_bytes(&cache_path).map_err(|err| Error::FileIo { | ||
| action: FileIoAction::Read, | ||
| kind: FileKind::File, | ||
| path: cache_path.clone(), | ||
| err: Some(err.to_string()), | ||
| })?; | ||
|
|
||
| serde_json::from_slice(&cached_result).map_err(|err| Error::FileIo { | ||
| action: FileIoAction::Read, | ||
| kind: FileKind::File, | ||
| path: cache_path, | ||
| err: Some(err.to_string()), | ||
| })? |
There was a problem hiding this comment.
cache reading concerns here as json source is unverifiable in current state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires gleam-lang/hexpm-rust#48
resolves #2162
Caches
/packages/{name}protobuf as a gz and/packages/{name}/releases/{version}as json for use in offline package resolution. Requests fail-over to use local caches.TODO: