-
-
Notifications
You must be signed in to change notification settings - Fork 873
feat(LS): Annotate all top level definitions
code action
#5019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, that's a great start! I left a couple of comments and questions inline
Annotate all top level type definitions
code actionAnnotate all top level definitions
code action
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic! I've left just two comments that need addressing, well done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we also have a test for partially annotated generic functions? For example:
pub fn wibble(a: a, b, c: c, d) {
todo
}
Hmm, interesting. Why it shows code action for annotated functions? It worked yesterday (I tested it in Zed and Neovim), but it doesn't now. |
Great, this looks good to me!! It only needs Louis' approval now :) |
They're not top level definitions, I added them by mistake, so removing
Co-authored-by: Giacomo Cavalieri <[email protected]>
Ah, CI was failed because of network issues |
Closes #4751
Add code action to add type annotation to all top level definitions.
Showcase
would become: