Add 'merge case branches' code action #5137
Open
+1,841
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Yes, I think so! Wouldn't be much use otherwise. |
Member
Author
|
Ok! I'm working on it |
giacomocavalieri
force-pushed
the
merge-case-branches
branch
2 times, most recently
from
7e9ff7c to
f5f45b6
Compare
Member
Author
|
Done! That ended up being quite a bit of boilerplate 😅 |
giacomocavalieri
force-pushed
the
merge-case-branches
branch
from
f5f45b6 to
4820431
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR I've implemented the code action to merge consecutive case branches. For now it's quite limited as it only supports branches whose body is a single
todo; @lpil do you think we should be comparing the ASTs to check if they can be safely merged?