🐛 Update manifest entry when dependency source changes #5141
+210
−115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fruno-bulax
commented
Nov 19, 2025
Comment on lines
602
to
642
| #[test] | ||
| fn resolved_with_updated() { | ||
| #[cfg(test)] | ||
| mod manifest_update_tests { |
Contributor
Author
There was a problem hiding this comment.
this diff is very confusing: I just moved the existing test into a module and added the resolved_with_source_type_change test below it.
lpil
reviewed
Nov 20, 2025
Member
lpil
left a comment
lpil
left a comment
There was a problem hiding this comment.
Oh thank you!! I was hoping to find time to do this this week. You're too fast for me!
One tiny note inline
compiler-core/src/manifest.rs
Outdated
| for new in &new.packages { | ||
| match old.remove(&new.name) { | ||
| // If the kind of source changed, the packages bear essentially no connection | ||
| Some(old) if discriminant(&old.source) != discriminant(&new.source) => { |
Member
There was a problem hiding this comment.
This function is magical and can also result in unexpected behaviour if misused. Please use a normal function with a match expression instead 🙏
pub fn kind(&self) -> ManifestPackageSourceKind {
match &self {
Self::Hex { .. } => ManifestPackageSource::Hex
// ...
Contributor
Author
There was a problem hiding this comment.
Trying to be too clever is a habit I'm working to get rid of 😅
Done!
fruno-bulax
force-pushed
the
change-pkg-source
branch
2 times, most recently
from
e13cd54 to
f330256
Compare
Contributor
Author
|
Converting this to a draft until I've addressed a related but different issue: #5132 (comment) |
fruno-bulax
force-pushed
the
change-pkg-source
branch
3 times, most recently
from
4cb7490 to
ca7dfd6
Compare
fruno-bulax
force-pushed
the
change-pkg-source
branch
from
ca7dfd6 to
96de24e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5132
Fixes #5084
When changing the type of source (like from hex to local), the manifest entry was not updated.
This causes gleam to hit hex for version resolution on each operation, quickly running into API limits.
Additionally, the manifest was not updated if there were only changes in requirements but not packages. This could happen if when changing version constraints or adding/removing a direct dependency to a package that is also a transitive dependency.
For this I split the
Resolvedstruct up, as some usages only cared about the package changes.