Prevent double opening of license link #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melissalinkert
approved these changes
Dec 18, 2025
Member
melissalinkert
left a comment
melissalinkert
left a comment
There was a problem hiding this comment.
I could easily reproduce the issue on Windows. After installing the build from this PR, clicking the license link now only opens it once. Code changes make sense to me.
It would be good to have double-check of functional testing on Mac, so assigning review to @erindiel (to either test or re-assign).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor issue discovered during the last testing cycle: In the "About" dialog clicking the GPL license link would open two copies of the web page rather than one.
Turns out that since we use a special hyperlink class from ControlsFX to only show the link on the desired text for that line of the About dialog, we need to prevent the event from being handled by the native JavaFX hyperlink class that was inherited from.