Add Java 25 to build matrix #294
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gradle >= 9.1.0 is required to run Java 25 builds, but 9.0.0 dropped support for Java < 17.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raised by @mabruce.
This is one approach to including Java 25 builds. Unfortunately, there is no Gradle version that can be run on both Java 8 and Java 25. See https://docs.gradle.org/current/userguide/compatibility.html. This PR as written keeps the existing Gradle wrapper, but separately downloads and installs 9.2.1 for the Java 25 build only. I feel like there must be some nicer way to do that, so other ideas welcome.
Compatibility with both Gradle 8.x.x and 9.x.x required a few adjustments to the
build.gradle, but that doesn't seem to be a problem. It's probably worth double-checking build logs and artifacts though to make sure everything looks reasonable.I'd imagine that whatever we settle on here can be applied to other repositories, so this is mostly a place to start the discussion and not necessarily something I expect to be merged as-is.