Improve handling of different connection types#32
Merged
emilroz merged 1 commit intoglencoesoftware:mainfrom Jun 10, 2025
Merged
Improve handling of different connection types#32emilroz merged 1 commit intoglencoesoftware:mainfrom
emilroz merged 1 commit intoglencoesoftware:mainfrom
Conversation
mabruce
reviewed
Jun 3, 2025
mabruce
approved these changes
Jun 9, 2025
Contributor
mabruce
left a comment
mabruce
left a comment
There was a problem hiding this comment.
I was able to successfully read a table via omero-user-token, omero.client, BlitzGateway, omero2pandas.connect.get_connection(BlitzGateway), and omero2pandas.connect_to_omero.
emilroz
approved these changes
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few changes here aimed at making the experience of using the connector interface a bit smoother. Overall goal is to allow users to supply either an OMEROConnection, BlitzGateway or omero.client object when interacting with omero2pandas using an existing connection.
get_connectionto theomero2pandas.connectmodule to better isolate it. Removed the underscore prefix to make this a bit more public. The basic gist of this function is to create a new OMEROConnection object using the supplied params, but avoid creating a nested object if the user already supplied an existing OMEROConnection instance.omero2pandas.remote.register_tablenow supports client/blitzgateway objects, not just OMEROConnections.detachOnDestroynew sessions created just for the o2p connector.