Writing tables to private groups#35
Merged
emilroz merged 1 commit intoglencoesoftware:mainfrom Jun 10, 2025
Merged
Conversation
DavidStirling
approved these changes
Jun 5, 2025
Contributor
DavidStirling
left a comment
There was a problem hiding this comment.
Change is sensible and fixes the problem case in question.
emilroz
approved these changes
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where an OriginalFile object created during table registration may incorrectly reference an ExternalInfo object owned by another user, rather than the active OMERO user. This generally goes unnoticed in shared groups (Read-Only, Read-Annotate, Read-Write), as read access is permitted across users. However, it leads to a SecurityViolation in private groups, where cross-user access is restricted.
To resolve this, the change introduces a shallow copy of the OriginalFile using a newly constructed OriginalFileI object. This ensures that ownership and related metadata are correctly set to match the current user context at creation time.