Change contentHiddenWhenClosed to set the css visibility instead of the html hidden property #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stops it from interfering with the content's scrollHeight fixing glennflanagan#194
Contributor
Author
|
If there were an is-transitioning or in-transition html class then content could be hidden via css selectors alone without needing to be an option in react-collapsible. |
|
Great that the bug is fixed! When can we expect it to be merged and released? |
Collaborator
Just want to make sure we're not going to regress, see my comment here #194 (comment)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stops it from interfering with the content's scrollHeight fixing #194.
I've also added two tests for this prop.