feat(kotlin): Support for date and datetime from JSON schema #2845
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for JSON Schema
format: date-time,format: date, andformat: timein the Kotlin code generator. These formats now generate properjava.time.*types instead ofString.This implementation follows the same pattern as Java's date-time support, using:
OffsetDateTimeforformat: "date-time"LocalDateforformat: "date"OffsetTimeforformat: "time"The feature works across all Kotlin frameworks:
just-types,jackson,klaxon, andkotlinx.Related Issue
Fixes #2460
Motivation and Context
We prefer Kotlin generation to Java generation for nullability propagation, but did not support datetime formatting, as Java does. Plus, saw there was a longstanding issue for this.
Previous Behaviour / Output
For the given JSON schema:
{ "$schema": "http://json-schema.org/draft-07/schema#", "type": "object", "properties": { "eventDate": { "type": "string", "format": "date" }, "eventTime": { "type": "string", "format": "time" }, "plannedDateTime": { "type": "string", "format": "date-time" } } }It would output:
New Behaviour / Output
How Has This Been Tested?
Manual Testing
--framework just-types--framework jackson--framework klaxon--framework kotlinxAutomated Testing
configuration
implementation (commit 1f89a97)