Skip to content

Fixed messageFormat dependency omission and a timezone-dependent test #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed messageFormat dependency omission and a timezone-dependent test #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/compile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ DEPENDENCIES_VARS = {
dateParserFn: true
},
messageFormatter: {
messageFormat: true,
messageFormatterFn: true
},
numberFormatter: {
Expand Down
14 changes: 7 additions & 7 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 9 additions & 3 deletions test/functional/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,15 @@ describe("The compiled `basic.js`", function() {
});

it("should include support for dateParser", function() {
var result = Globalize.dateParser({skeleton: "MMMd", timeZone: "America/New_York"})("Jan 1");
expect(result.getMonth()).to.equal(0);
expect(result.getDate()).to.equal(1);
// When it is Feb 23 in New York, it has already been Feb 23rd in GMT for 4 or 5 hours (depending on DST).
var inNewYorkTime = Globalize.dateParser({skeleton: "MMMd", timeZone: "America/New_York"})("Feb 23");
expect(inNewYorkTime.getUTCMonth()).to.equal(1);
expect(inNewYorkTime.getUTCDate()).to.equal(23);

// When it is Feb 23 in Oslo, it is not yet (by 1 hour) Feb 23rd in GMT.
var inOsloTime = Globalize.dateParser({skeleton: "MMMd", timeZone: "Europe/Oslo"})("Feb 23");
expect(inOsloTime.getUTCMonth()).to.equal(1);
expect(inOsloTime.getUTCDate()).to.equal(22);
});

it("should include support for parseDate", function() {
Expand Down
3 changes: 3 additions & 0 deletions test/unit/fixtures/basic.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@ console.log(Globalize.formatDateToParts(new Date(), {date: "long"}));
var dateParser = Globalize.dateParser({skeleton: "MMMd", timeZone: "America/New_York"});
console.log(dateParser("Jan 1"));

dateParser = Globalize.dateParser({skeleton: "MMMd", timeZone: "Europe/Oslo"});
console.log(dateParser("Jan 1"));

// Use parseDate.
console.log(Globalize.parseDate("1/2/1982"));

Expand Down