Skip to content

♿ feat: implement accessibility improvements #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ana-maria-silva wants to merge 1 commit into
base: master
Choose a base branch
from
Open

♿ feat: implement accessibility improvements #446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions website/components/header.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,11 @@ export default function Header() {
text editor ever.
</h1>
<div className="hero__description">
Megadraft is a Rich Text editor built on top of
<header>Megadraft is a Rich Text editor built on top of
Copy link
Contributor

@lucaxsilveira lucaxsilveira Oct 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Não acho que aqui seja a melhor opção pra adicionar o header, poderia rever o uso pra uma div superior? Se atentar a indentação também nesse caso

Copy link
Contributor Author

@ana-maria-silva ana-maria-silva Oct 31, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Necessário revisar o código do projeto, para implementação de melhorias para acessibilidade e usabilidade de acordo com as diretrizes da web semântica.

Copy link
Contributor Author

@ana-maria-silva ana-maria-silva Oct 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Realmente, revisando esta sugestão, neste caso, o mais recomendado seria <h2> seguindo a hierarquia de títulos, assim como para toda a estrutura utilizando <main>, <article> ,<aside>, <figure> e <nav> para o menu.

Copy link

@paulpessoa paulpessoa Oct 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muito bem observado, mas está quase lá!
Considerando boas práticas de acessibilidade,
o texto não deveria estar dentro de uma tag apropriada, como h, p, span, etc.
O que acha?

Copy link
Contributor Author

@ana-maria-silva ana-maria-silva Oct 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correto, neste caso, o mais recomendado seria <h2> seguindo a hierarquia de títulos, assim como para toda a estrutura utilizando <main>, <article> e <aside> para o conteúdo, <figure> para a imagem e <nav> para o menu.

<br />
Facebook's draft.js featuring a nice default
<br />
base of plugins and extensibility.
base of plugins and extensibility.</header>
</div>
</div>
</div>
Expand Down
4 changes: 2 additions & 2 deletions website/index_tpl.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<!DOCTYPE html>
<html>
<html lang="pt-br">
Copy link

@paulpessoa paulpessoa Oct 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

O default idioma aqui esta pt-br mas todo o conteúdo é em inglês

<head>
<meta charset="utf-8" />
<title>Megadraft - Draft.JS Rich Text Editor</title>
Expand All @@ -16,7 +16,7 @@
<meta name="robots" content="all" />
<meta name="viewport" content="width=device-width, initial-scale=1" />

<meta property="og:url" content="https://globocom.github.io/megadraft" />
<meta property="og:url" content="https://megadraft.io/#/" />
<meta property="og:title" content="Megadraft - Draft.JS Rich Text Editor" />
<meta
property="og:description"
Expand Down