Skip to content

Remove the web_client and login_manager modules#2079

Merged
chris-janidlo merged 1 commit intomainfrom
chris/deprecated-modules/sc-47792/sc-48078
Mar 17, 2026
Merged

Remove the web_client and login_manager modules#2079
chris-janidlo merged 1 commit intomainfrom
chris/deprecated-modules/sc-47792/sc-48078

Conversation

@chris-janidlo
Copy link
Contributor

@chris-janidlo chris-janidlo commented Mar 12, 2026

Description

These have been deprecated for a year or so. They're fairly heavily intertwined, so remove both at once.

Type of change

  • Code maintenance/cleanup

@chris-janidlo chris-janidlo force-pushed the chris/deprecated-modules/sc-47792/sc-48078 branch from 0cee65c to 85e2529 Compare March 16, 2026 16:16
@chris-janidlo chris-janidlo marked this pull request as ready for review March 16, 2026 16:40
khk-globus
khk-globus previously approved these changes Mar 16, 2026
Copy link
Contributor

@khk-globus khk-globus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chris-janidlo chris-janidlo force-pushed the chris/deprecated-modules/sc-47792/sc-48078 branch from 85e2529 to acc7480 Compare March 16, 2026 20:59
These have been deprecated for a year or so. They're fairly heavily
intertwined, so remove both at once.

[sc-47792]
[sc-48078]
@chris-janidlo chris-janidlo force-pushed the chris/deprecated-modules/sc-47792/sc-48078 branch from acc7480 to 2cf2887 Compare March 16, 2026 21:06
@chris-janidlo chris-janidlo merged commit 5bf16b3 into main Mar 17, 2026
12 of 13 checks passed
@chris-janidlo chris-janidlo deleted the chris/deprecated-modules/sc-47792/sc-48078 branch March 17, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants