Skip to content

Build links to the Flows IDE for rendered pages#17

Merged
sirosen merged 1 commit intoglobus:mainfrom
sirosen:create-links
Aug 6, 2025
Merged

Build links to the Flows IDE for rendered pages#17
sirosen merged 1 commit intoglobus:mainfrom
sirosen:create-links

Conversation

@sirosen
Copy link
Member

@sirosen sirosen commented Aug 5, 2025

Update the build-doc-bundle script to create a gzip-encoded link to the example flows in the Flows IDE.

The IDE link is passed to the asciidoc content by setting it as an attribute of the doc, which the content can then reference in a link: directive.
For now, as a simple matter of simplicity and uniformity, the link is dropped, unadorned, at the top of each page where it is supported.

Because the compute examples contain multiple definitions and therefore can't build simple links, an exclude config is supported to disable the links for these examples.


I've done a test render and confirmed that the Flows IDE is able to read these links.
Here's what a render will look like on the docs site:
image

kurtmckee
kurtmckee previously approved these changes Aug 5, 2025
@kurtmckee kurtmckee dismissed their stale review August 5, 2025 16:59

mypy is failing.

Update the `build-doc-bundle` script to create a gzip-encoded link to
the example flows in the Flows IDE.

The IDE link is passed to the asciidoc content by setting it as an
attribute of the doc, which the content can then reference in a
`link:` directive.
For now, as a simple matter of simplicity and uniformity, the link is
dropped, unadorned, at the top of each page where it is supported.

Because the compute examples contain multiple definitions and
therefore can't build simple links, an exclude config is supported to
disable the links for these examples.
@sirosen
Copy link
Member Author

sirosen commented Aug 5, 2025

I forgot to handle the flows_ide_link=None case. It resulted in harmless but wrong rendering of :flows_ide_link: None in the asciidoc output. Fixed in an amend, which makes the preamble function a little bit fancier.

I compared the result to confirm it's still good.

@sirosen sirosen merged commit c62b310 into globus:main Aug 6, 2025
2 checks passed
@sirosen sirosen deleted the create-links branch August 6, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants