Skip to content

Remove unnecessary invalidate. #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove unnecessary invalidate. #18

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8fd98a
Remove unnecessary invalidate.
christmasjason Aug 3, 2016
4f78659
Update CodeInput.java
christmasjason Aug 3, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions codeinputlib/src/main/java/com/github/glomadrian/codeinputlib/CodeInput.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,7 @@ private void reverseAnimation() {
@Override public boolean onKeyDown(int keyCode, KeyEvent keyevent) {
if (keyCode == KeyEvent.KEYCODE_DEL && characters.size() != 0) {
characters.pop();
invalidate();
}
return super.onKeyDown(keyCode, keyevent);
}
Expand All @@ -246,6 +247,7 @@ private void reverseAnimation() {
if (matcher.matches()) {
char character = matcher.group(1).charAt(0);
characters.push(character);
invalidate();
if (characters.size() >=underlineAmount){
if(listener!=null) {
listener.onCodeReady(getCode());
Expand Down Expand Up @@ -287,7 +289,6 @@ private void reverseAnimation() {
if (hintText != null) {
drawHint(canvas);
}
invalidate();
}

private void drawSection(int position, float fromX, float fromY, float toX, float toY,
Expand Down Expand Up @@ -320,8 +321,8 @@ public Character[] getCode() {
private class ReductionAnimatorListener implements ValueAnimator.AnimatorUpdateListener {

public void onAnimationUpdate(ValueAnimator valueanimator) {
float value = ((Float) valueanimator.getAnimatedValue()).floatValue();
reduction = value;
reduction = (float) valueanimator.getAnimatedValue();
invalidate();
}
}

Expand All @@ -332,6 +333,7 @@ private class HintYAnimatorListener implements ValueAnimator.AnimatorUpdateListe

@Override public void onAnimationUpdate(ValueAnimator animation) {
hintActualMarginBottom = (float) animation.getAnimatedValue();
invalidate();
}
}

Expand All @@ -343,6 +345,7 @@ private class HintSizeAnimatorListener implements ValueAnimator.AnimatorUpdateLi
@Override public void onAnimationUpdate(ValueAnimator animation) {
float size = (float) animation.getAnimatedValue();
hintPaint.setTextSize(size);
invalidate();
}
}
}