Open
Conversation
janbridley
approved these changes
Apr 3, 2026
spatula/pgop.py
Outdated
| optimizer: spatula.optimize.Optimizer, | ||
| mode: str = "full", | ||
| compute_per_operator_values_for_final_orientation: bool = False, | ||
| metric: str = "BC", |
Contributor
There was a problem hiding this comment.
My only note is I think this could be "hillinger" and "bhattacharyya", with typing.Literal it should autocomplete and it's more explicit
Contributor
There was a problem hiding this comment.
I've implemented these changes - @DomFijan let me know if this works for you!
janbridley
reviewed
Apr 3, 2026
janbridley
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Provide an alternative metric for neighborhood similarity which obeys triangle inequality.
Motivation and Context
Can be useful for certain analysis where OP distance should obey triangle inequality.
How Has This Been Tested?
Tests have been written.
Checklist: