Skip to content

Conversation

@f2cmb
Copy link
Contributor

@f2cmb f2cmb commented Oct 14, 2025

Description

Copy link
Contributor

@AdrienClairembault AdrienClairembault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The goal of the orignal css is to align the content somewhat to the left.

Before:

Image

After:
Image

While the before is not perfect, the after seems too agressive as the content is pushed almost to the middle of the screen.

Maybe a compromise can be found by adding only a bit more space?

@cedric-anne cedric-anne added the ui label Oct 15, 2025
@cedric-anne cedric-anne added this to the 11.0.2 milestone Oct 15, 2025
@f2cmb
Copy link
Contributor Author

f2cmb commented Oct 20, 2025

One alternative would be, to stick to the principle while being respectful of the existing CSS framework instead of using the glpi-full-width calc values, to modify these https://github.com/glpi-project/glpi/blob/11.0/bugfixes/templates/components/form/fields_macros.html.twig#L907-L910 and change columns to col-xxl-4 / col-xxl-8 distribution

@f2cmb
Copy link
Contributor Author

f2cmb commented Oct 20, 2025

Goes back to using .col-12.glpi-full-width targeting to limit new value to ticket form fields @AdrienClairembault

@AdrienClairembault AdrienClairembault marked this pull request as ready for review October 20, 2025 13:40
@trasher
Copy link
Contributor

trasher commented Oct 21, 2025

Please fix lint

@orthagh
Copy link
Contributor

orthagh commented Oct 22, 2025

Maybe I wasn't clear. I don't want any modification in css that apply on the whole GLPI. This may lead to issues in other parts.

I would like to have a test with passing different values of label_class and input_class in the field_options of the templates/components/itilobject/fields_panel.html.twig file.
I think it should help with a better proportion of the right panel of tickets.

Copy link
Contributor

@orthagh orthagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above comment

@f2cmb
Copy link
Contributor Author

f2cmb commented Oct 28, 2025

So. In ff112c2 i revert glpi-full-width / col-12, and add to combine adding a new class and new css rules to fix. Wasn't possible or simple (i prefer avoid conditions on macros and that kind of workarounds) to only fix in template.

In addition, the fix is added to fields of others Itil objects like problems and changes, as the exact same issue could be created later for those.

Copy link
Contributor

@trasher trasher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting for @orthagh review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Line breaking Text in Brazilian Portuguese

5 participants