-
-
Couldn't load subscription status.
- Fork 1.5k
Fix linebreak on form field in ticket view #21478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 11.0/bugfixes
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
One alternative would be, to stick to the principle while being respectful of the existing CSS framework instead of using the glpi-full-width calc values, to modify these https://github.com/glpi-project/glpi/blob/11.0/bugfixes/templates/components/form/fields_macros.html.twig#L907-L910 and change columns to col-xxl-4 / col-xxl-8 distribution |
|
Goes back to using .col-12.glpi-full-width targeting to limit new value to ticket form fields @AdrienClairembault |
|
Please fix lint |
|
Maybe I wasn't clear. I don't want any modification in css that apply on the whole GLPI. This may lead to issues in other parts. I would like to have a test with passing different values of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above comment
|
So. In ff112c2 i revert glpi-full-width / col-12, and add to combine adding a new class and new css rules to fix. Wasn't possible or simple (i prefer avoid conditions on macros and that kind of workarounds) to only fix in template. In addition, the fix is added to fields of others Itil objects like problems and changes, as the exact same issue could be created later for those. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, waiting for @orthagh review.


Description