Fix networkport connection log creation #21493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix Twig display closes glpi-project#21488
cedric-anne
reviewed
Oct 15, 2025
|
Tests are broken, I do not yet know why. Proposed fix is probably incorrect, I put back as draft. |
The JS test for the dashboard joke failed :( |
|
Finally, I've converted to Should I port that change on v10 as well? (otherwise, issue will be fixed only for v11 - I'd be OK with that). |
cedric-anne
approved these changes
Oct 27, 2025
IMHO, this is not a major issue. There is no need to backport it to the 10.0 branch. |
AdrienClairembault
approved these changes
Oct 27, 2025
cedric-anne
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix Twig display
closes #21488