Skip to content

Add a message when CommonDBChild item creation is refused #21524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: 11.0/bugfixes
Choose a base branch
from
Draft

Add a message when CommonDBChild item creation is refused #21524

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/CommonDBChild.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,6 +440,11 @@ public function prepareInputForAdd($input)
static::$mustBeAttached
&& !$this->getItemFromArray(static::$itemtype, static::$items_id, $input)
) {
Session::addMessageAfterRedirect(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this seems indeed a good idea, maybe we should rely on something more similar than checkAttachedItemChangesAllowed() do.

__s('Parent item is invalid.'),
true,
ERROR
);
return false;
}

Expand All @@ -460,6 +465,7 @@ public function prepareInputForUpdate($input)
static::$items_id,
])
) {
// A message is already added by `self::checkAttachedItemChangesAllowed()`
return false;
}

Expand Down
Loading