Skip to content

Conversation

@Lainow
Copy link
Contributor

@Lainow Lainow commented Oct 22, 2025

Checklist before requesting a review

Please delete options that are not relevant.

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.
  • This change requires a documentation update.

Description

  • It fixes !39815
  • Here is a brief description of what this PR does
    When a user has been assigned rights by the rules, if they no longer match the rules, these rights are withdrawn and the default right is not restored. They are therefore left without authorization.

Screenshots (if appropriate):

@Lainow Lainow self-assigned this Oct 22, 2025
@trasher
Copy link
Contributor

trasher commented Oct 22, 2025

This needs a test case

@Lainow Lainow changed the base branch from 11.0/bugfixes to 10.0/bugfixes October 22, 2025 09:13
@trasher trasher added this to the 10.0.21 milestone Oct 22, 2025
Copy link
Contributor

@trasher trasher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (waiting for tests results). You still have to revert composer.json changes

Co-authored-by: Johan Cwiklinski <[email protected]>
@Lainow Lainow requested review from stonebuzz and trasher October 22, 2025 10:08
@AdrienClairembault
Copy link
Contributor

Is there a chance some users might expect the original behavior as a way to disable a user?

@Lainow
Copy link
Contributor Author

Lainow commented Oct 22, 2025

Is there a chance some users might expect the original behavior as a way to disable a user?

It seems more logical to me to restore the default permissions to a user who no longer has specific rights. To disable them, you would simply switch the user to Active: No.

@Lainow Lainow force-pushed the fix-no-default-profile-before-sync branch from 8aa1a4e to b27ae9f Compare October 22, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants