Fix color field ID mismatch in template macros #21649
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rom1-B
approved these changes
Oct 27, 2025
|
Patch sent to the partner : waiting for validation feedback |
cedric-anne
reviewed
Oct 27, 2025
|
|
||
| <script> | ||
| $(function () { | ||
| $("#{{ options.id|e('css')|e('js') }}").spectrum({ |
There was a problem hiding this comment.
#21483 should permit to not have to change the selector.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
It fixes !39937
The color picker no longer appears when clicking on the affected fields; only the color value in text (hexadecimal) is visible.
This issue was caused by an ID mismatch: different IDs were assigned by the color and field macros. The color macro script applied CSS and JS escaping on the ID for security reasons (see related PRs below), which created inconsistencies.
This fix:
Links to related PRs : #21483 - #21246