[WIP] Validate id before adding link#22879
Draft
eduardomozart wants to merge 12 commits intoglpi-project:11.0/bugfixesfrom
Draft
[WIP] Validate id before adding link#22879eduardomozart wants to merge 12 commits intoglpi-project:11.0/bugfixesfrom
eduardomozart wants to merge 12 commits intoglpi-project:11.0/bugfixesfrom
Conversation
Add validation for suppliers_id field in contact supplier form
cedric-anne
approved these changes
Jan 29, 2026
trasher
reviewed
Jan 29, 2026
eduardomozart
changed the title
Refactor supplier contact validation to use exception handling.
cedric-anne
previously approved these changes
Jan 29, 2026
AdrienClairembault
previously approved these changes
Jan 29, 2026
Handle ItemLinkException when checking item project.
Handle ItemLinkException during cartridge item creation.
Added error handling for item line creation.
Add error handling for software license creation.
3 tasks
Handle ItemLinkException when checking certificate item.
Added validation for mandatory fields when adding items.
Wrap check method in try-catch to handle ItemLinkException.
trasher
dismissed stale reviews from cedric-anne, AdrienClairembault, and themself
PR in draft
AdrienClairembault
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add validation for suppliers_id field in contact supplier form
Checklist before requesting a review
Please delete options that are not relevant.
Description
Implement similar verification made at https://github.com/glpi-project/glpi/edit/11.0/bugfixes/front/contract_supplier.form.php
Screenshots (if appropriate):