fix: accordion content overflows below card border in All Components …#3383
fix: accordion content overflows below card border in All Components …#3383Abhijadhav03 wants to merge 1 commit intogluestack:mainfrom
Conversation
|
@Abhijadhav03 is attempting to deploy a commit to the GeekyAnts Labs Team on Vercel. A member of the Team first needs to authorize it. |
|
Hey @Sanchitv3 ! let me know if you’d like any changes on this PR. I’m happy to make updates if needed. |
|
Hey @Abhijadhav03, thanks for the fix and the detailed explanation 🙌 The current behavior on the website is actually intentional. The cards are designed with a fixed height ( If we allow the card to grow dynamically based on accordion content, it can lead to inconsistent card sizes on the “All Components” page, which affects the overall grid alignment and showcase aesthetics. So in this case, the overflow is expected behavior as part of the design trade-off. We might explore a better pattern later (like internal scroll or a different preview strategy), but for now we’d prefer to keep the fixed-height approach. Appreciate the contribution, feel free to take up another issue! 🚀 |
|
Hey @Sanchitv3 👋 I made a cleaner fix that keeps the fixed card height while solving the overflow issue — no dynamic growth, no scroll, and grid alignment stays intact only thing i did was reduce the text size !. Here's the updated look: gluestack.mp4Let me know what you think! Happy to update the PR if this works better. Thanks! |
|
Hey @Abhijadhav03 , |
78c8db7 to
c5b53b8
Compare
|
Hey @Sanchitv3, Thanks for the feedback! I've updated the PR with a cleaner fix that keeps the fixed card height:
PR Link: #3383 Let me know what you think! |
Description
Fixed a layout issue where accordion content would overflow and spill below the card border when expanded on the all-components demo page, breaking the visual container integrity.
Problem Statement
When users expanded accordion items on the all-components page, the expanded content would overflow beyond the card's bottom border instead of being properly contained. This created a broken visual experience where content appeared to "break through" the card boundary.
Solution
Modified the card layout in
/apps/website/components/page-components/all-components/index.tsx:Changes made:
h-[300px])hiddentoautofor scrollable overflowmin-h-[300px]to maintain minimum card heightflex-colfor proper vertical stackingp-4padding for better content spacingrounded-b-lgfor visual polishTesting
/ui/docs/components/all-componentsRelated Issues
Fixed #3382