chore(lib): upgrade fluent-uri dependency, address TOUCH-UP comments#299
Closed
WillLillis wants to merge 2 commits intogluon-lang:masterfrom
Closed
chore(lib): upgrade fluent-uri dependency, address TOUCH-UP comments#299WillLillis wants to merge 2 commits intogluon-lang:masterfrom
WillLillis wants to merge 2 commits intogluon-lang:masterfrom
Conversation
Author
|
Ah, I see this is essentially a duplicate of #294. Apologies for the noise! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has two changes:
I noticed the two
TOUCH-UPcomments while reading through the crate, and saw that the relevant functionality has been implemented upstream. I bumped thefluent-uridependency to its latest version, and addressed theTOUCH-UPcomments in the first commit.I also addressed all of the warnings issued by clippy. I'm happy to revert/add some
#[ignore()]macros instead if these changes aren't desirable :).