Skip to content

Comments

Netperf#4

Open
sac wants to merge 6 commits intogluster:masterfrom
sac:netperf
Open

Netperf#4
sac wants to merge 6 commits intogluster:masterfrom
sac:netperf

Conversation

@sac
Copy link
Member

@sac sac commented Jul 23, 2019

No description provided.

@@ -0,0 +1,40 @@
network_perf
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also update the README.md with this role description?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the role called network_perf?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is called perf. Earlier I had named it network_perf, since we do lot of other tests I renamed the role to perf. This is a typo, I will fix it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

network_perf
=========

Gathers the network performance on the nodes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this role only gathering the network performance? How about the cpu, memory and disk stats?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it is not just the network performance, but disk and other performance tests are run as well. I will update the description.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.


netperf3

Example Playbook
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

provide a more detailed example?
Isn't the gluster volume on which the tests need to be run needed as an input?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. We need it, actually we check the mandatory variables in the role:

       assert:
         that:
            - "{{item}} is defined"
         fail_msg: "FAIL: variable {{item}} not set"
         success_msg: "PASS: variable {{item}} is defined."
       run_once: true
       delegate_to: localhost
       with_items:
         - gluster_maintenance_volname
         - gluster_maintenance_mountpoint
         - gluster_maintenance_client

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

| gluster_maintenance_net_nodes | Yes | | UNDEF | List of nodes on which to collect the network performance numbers. |
| gluster_maintenance_net_single | No | | First node in the list | Collect the perf numbers from all nodes to one lead host |
| gluster_maintenance_net_ping_duration | No | | 10 | Ping counter |
| gluster_maintenance_net_iperf_duration | No | | 30 | iperf timer; time in seconds to transmit for |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing the variables required

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I will add them. I remember documenting all the variables, I will check and add.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

------------

gluster-ansible
netperf3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any other pre-requisites needed? VM to be created?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. But conventionally only the package requirements are listed here. This is more like dependency list.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a specific test to customers who are storing VM data on GlusterFS. I have added NOTES file which contains the comments from a bug.

with_items:
- gluster_maintenance_volname
- gluster_maintenance_mountpoint
- gluster_maintenance_client
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the difference between gluster_maintenance_client and gluster_maintenance_vm ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gluster_maintenance client is the GlusterFS client. And vm is the virtual machine stored on GlusterFS.

tags:
- vmservicestart

- name: Run fio tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assumes fio is installed? Should there be a step to install fio if not present?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I'm not sure if fio comes as part of rhel/rhgs subscription. But we can add them.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@sabose
Copy link
Member

sabose commented Oct 23, 2019

@sac the fio tests seem to be run twice on the VM.
Also, the playbook errored out with :
FAILED! => {"changed": true, "cmd": "gluster volume profile data info incremental > /var/tmp/perf-results/ioresults_VM-1/seq-write-profile.txt", "delta": "0:00:00.002804", "end": "2019-10-22 18:36:39.516121", "msg": "non-zero return code", "rc": 1, "start": "2019-10-22 18:36:39.513317", "stderr": "/bin/sh: /var/tmp/perf-results/ioresults_VM-1/seq-write-profile.txt: No such file or directory", "stderr_lines": ["/bin/sh: /var/tmp/perf-results/ioresults_VM-1/seq-write-profile.txt: No such file or directory"], "stdout": "", "stdout_lines": []}

Copy link
Member Author

@sac sac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have fixed this. I think I lost the earlier changes. I had run this role successfully a few times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants