add support for parsing HLS WebVTT X-TIMESTAMP-MAP tag#25
Open
omerholz wants to merge 3 commits intoglut23:masterfrom
omerholz:hls-webvtt-timestamp-map-support
Open
add support for parsing HLS WebVTT X-TIMESTAMP-MAP tag#25omerholz wants to merge 3 commits intoglut23:masterfrom omerholz:hls-webvtt-timestamp-map-support
omerholz wants to merge 3 commits intoglut23:masterfrom
omerholz:hls-webvtt-timestamp-map-support
Conversation
Contributor
Author
|
@glut23 would love your feedback |
Owner
|
Hi @omerholz apologies for replying this late. I am thinking that we could incorporate this parsing functionality as part of the WebVTT class, so the user can parse a vtt file and read the HLS data if present. What do you think? Thanks for your contribution. |
Contributor
Author
|
I'm game to place it there @glut23 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding support for parsing HLS WebVTT X-TIMESTAMP-MAP tag.
for more details see: https://tools.ietf.org/html/rfc8216#section-3.5
This PR keeps full backward compatibility. It adds a new structure
TimestampMapto store the timestamp map, a new parserHlsWebVTTParserto parse webvtt payload that may or may not haveX-TIMESTAMP-MAPtag and a newHlsWebVTTclass to tie everything together: